Add Inspect to builtins #5747
Merged
Add Inspect to builtins #5747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtfeldman
force-pushed
the
inspect-builtin
branch
from
e345244
to
6b9592a
Compare
rtfeldman
commented
Aug 14, 2023
crates/compiler/mono/src/layout.rs
Outdated
| Alias(Symbol::INSPECT_ELEM_WALKER | Symbol::INSPECT_KEY_VAL_WALKER, _, var, _) => Self::from_var(env, var), | ||
|
|
||
| Alias(symbol, _, _, _) if symbol.is_builtin() => { | ||
| unreachable!("Need to special-case this builtin, like the ones above: {:?}", symbol); |
There was a problem hiding this comment.
Turns out some builtins need to be handled differently from others. Before this change, we were getting errors where Inspect.ElemWalker was specializing to have 3 symbols but 0 layouts because its layout was incorrectly being cached as a 0-arg thunk.
Added this unreachable! so that if this happens again in the future, it will be clearer where to apply the fix!
Keep getting errors in the build ruby example on Json, and it doesn't tell me the name of the symbol, just the IdentId, which makes this really hard to track down. This approach works fine, it'll just be harder to debug the next time we run into a special case like ElemWalker.
Anton-4
previously approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.