Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give better error messages when provides is missing in header #5623

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Give better error messages when provides is missing in header #5623

merged 3 commits into from
Jun 27, 2023

Conversation

KilianVounckx
Copy link
Contributor

Fixes this issue

@Anton-4
Copy link
Collaborator

Anton-4 commented Jun 27, 2023

Thanks @KilianVounckx :)
Could you add a test for this case (as shown in the issue) as well?

@KilianVounckx
Copy link
Contributor Author

Do I just add a test at the end of crates/reporting/tests/test_reporting.rs for this?

@Anton-4
Copy link
Collaborator

Anton-4 commented Jun 27, 2023

It would probably be best to add it after this test

Anton-4
Anton-4 approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@Anton-4 Anton-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Anton-4 Anton-4 enabled auto-merge June 27, 2023 19:05
@Anton-4 Anton-4 merged commit fd5616d into roc-lang:main Jun 27, 2023
@KilianVounckx KilianVounckx deleted the provides-error-message branch June 28, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anton-4 Anton-4 Anton-4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provide good error message when provides... is forgotten in the header
2 participants
@KilianVounckx @Anton-4