Implement function erasure #5576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayazhafiz
force-pushed
the
spike-erasure
branch
2 times, most recently
from
725f3af
to
89dbf5a
Compare
This new flag determines whether we should introduce a new kind to represent lambda sets, or whether lambdas should be erased. The latter is not yet implemented.
But none of these paths are yet exercised.
folkertdev
approved these changes
Jul 17, 2023
Comment on lines
+1450
to
+1455
| let box1_is_null = env | ||
| .builder | ||
| .build_is_null(box1.into_pointer_value(), "box1_is_null"); | ||
| let check_box2_is_null = ctx.append_basic_block(parent, "check_if_box2_is_null"); | ||
| let return_false = ctx.append_basic_block(parent, "return_false"); | ||
| let compare_inner_values = ctx.append_basic_block(parent, "compare_inner_values"); |
There was a problem hiding this comment.
this adds an extra block. you could just do the null checks, bitwise or, and then jump based on that right?
| } | ||
|
|
||
| impl<T> SubsSlice<T> { | ||
| pub fn empty() -> Self { |
There was a problem hiding this comment.
could be a const fn now I think.
This was referenced Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements type-erasure of closures, as an alternative to lambda sets for compiling functions.
See the description of erasure here: https://www.notion.so/rwx/Type-Erasure-a3ed13ef1305422eba00dbda026e52b3?pvs=4
The current implementation supports only global function erasure, and is internal-only. You can compile a roc program with erased functions using a debug compiler and setting
ROC_ERASE=1.The implementation is incomplete but I would like to merge this in, as we need it regardless, and the diff is quite large. Currently unsupported: