Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix desugar step for pizza operator #5481

Merged
merged 5 commits into from
Jul 10, 2023
Merged

Fix desugar step for pizza operator #5481

merged 5 commits into from
Jul 10, 2023

Conversation

kdziamura
Copy link
Collaborator

Closes #5379

@kdziamura kdziamura force-pushed the fix_pizza branch 2 times, most recently from b81ceb2 to 4bb7b84 Compare June 22, 2023 22:56
@kdziamura
Copy link
Collaborator Author

kdziamura commented Jun 22, 2023 •
edited
Loading

Struggling with stack overflow in tests. An example of failure:

---- glue_cli_run::union_without_padding stdout ----
thread 'glue_cli_run::union_without_padding' panicked at '`roc glue` command had unexpected stderr:
thread 'main' has overflowed its stack
fatal runtime error: stack overflow
', crates/glue/tests/test_glue_cli.rs:217:13

UPD. with --release the tests are passed

@kdziamura kdziamura force-pushed the fix_pizza branch 2 times, most recently from 3145929 to ad4389d Compare July 3, 2023 13:46
@kdziamura kdziamura mentioned this pull request Jul 3, 2023
Open
@kdziamura kdziamura requested a review from rtfeldman July 4, 2023 08:25
@kdziamura
Copy link
Collaborator Author

@rtfeldman any blockers here?

rtfeldman
rtfeldman approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@rtfeldman rtfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!!! 😍

Thanks so much for making this happen @wontem! I'm really excited to have this improvement! 😃

@rtfeldman rtfeldman merged commit b2ce9d1 into roc-lang:main Jul 10, 2023
@kdziamura kdziamura deleted the fix_pizza branch July 10, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtfeldman rtfeldman rtfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipes ignore parenthesis wrapping an application
2 participants
@kdziamura @rtfeldman