Have List.withCapacity lowlevel use u64 over usize

roc-lang · Feb 1, 2024 · 0b42a90 · 0b42a90
1 parent aabd954
commit 0b42a90
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 18 deletions.
diff --git a/crates/compiler/builtins/bitcode/src/list.zig b/crates/compiler/builtins/bitcode/src/list.zig
@@ -472,7 +472,7 @@ pub fn listMap4(
 }
 
 pub fn listWithCapacity(
-    capacity: usize,
+    capacity: u64,
     alignment: u32,
     element_width: usize,
 ) callconv(.C) RocList {

diff --git a/crates/compiler/gen_llvm/src/llvm/expect.rs b/crates/compiler/gen_llvm/src/llvm/expect.rs
@@ -978,22 +978,18 @@ fn build_clone_builtin<'a, 'ctx>(
             cursors.extra_offset
         }
 
-        Builtin::Str => {
-            //
-
-            call_str_bitcode_fn(
-                env,
-                &[value],
-                &[
-                    ptr.into(),
-                    cursors.offset.into(),
-                    cursors.extra_offset.into(),
-                ],
-                crate::llvm::bitcode::BitcodeReturns::Basic,
-                bitcode::STR_CLONE_TO,
-            )
-            .into_int_value()
-        }
+        Builtin::Str => call_str_bitcode_fn(
+            env,
+            &[value],
+            &[
+                ptr.into(),
+                cursors.offset.into(),
+                cursors.extra_offset.into(),
+            ],
+            crate::llvm::bitcode::BitcodeReturns::Basic,
+            bitcode::STR_CLONE_TO,
+        )
+        .into_int_value(),
         Builtin::List(elem) => {
             let bd = env.builder;
 

diff --git a/crates/compiler/gen_wasm/src/low_level.rs b/crates/compiler/gen_wasm/src/low_level.rs
@@ -459,7 +459,7 @@ impl<'a> LowLevelCall<'a> {
 
                 // Zig arguments              Wasm types
                 //  (return pointer)           i32
-                //  capacity: usize            i32
+                //  capacity: u64              i64
                 //  alignment: u32             i32
                 //  element_width: usize       i32