Remove unused recursive call #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading an EncryptedKey element, we call XMLSecEnc::staticLocateKeyInfo() to see if there's another KeyInfo element inside. This could happen when we have more than one level of key encryption. However, the static method does not modify the DOM or the key passed as parameters, it returns the key (or a new one). Given that the result of the call is never assigned to $objKey, this has never actually worked. It makes sense, since the most common escenario is data encrypted with a random symmetric key, and then that session key being sent alongside the cipherdata, in turn encrypted with the public key of the recipient. We could fix this instead of just removing the line. However, given that it wasn't working, indicates there's no use for it. Fixing it on the other hand would require quite a lot of logic to limit the amount of recursion allowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading an EncryptedKey element, we call XMLSecEnc::staticLocateKeyInfo() to see if there's another KeyInfo element inside. This could happen when we have more than one level of key encryption. However, the static method does not modify the DOM or the key passed as parameters, it returns the key (or a new one). Given that the result of the call is never assigned to $objKey, this has never actually worked. It makes sense, since the most common escenario is data encrypted with a random symmetric key, and then that session key being sent alongside the cipherdata, in turn encrypted with the public key of the recipient.
We could fix this instead of just removing the line. However, given that it wasn't working, indicates there's no use for it. Fixing it on the other hand would require quite a lot of logic to limit the amount of recursion allowed.