Append signature after a specific node

[seorefbe]

Hello,

To be compliant with urn:oasis:names:tc:SAML:2.0:protocol in a RequestedAuthnContext, the signature have to be append just after the Issuer node.

I need the possibility to define a position in function appendSignature.

Have a good day,

Sébastien

[robrichards]

This would be better off passing a reference node rather than a position. I would expect a developer to have access to the node it would be inserted before or after rather than knowing what position it lives within the subtree.

[hebertreis]

Libera isso aiiii

[hebertreis]

Please accept this pull request!

[falinhares]

Was this pull request accepted?

[seorefbe]

Was this pull request accepted?

nop :(

[tvdijen]

@seorefbe Perhaps for your SAML2 use-case you can use https://github.com/simplesamlphp/saml2
It's a low-level saml2-library that does most of the heavy lifting for you regarding singing/encryption.

[falinhares]

I have a tricky SOAP xml that I have to sign just after a element. Any thoughts on how can I do this?

[tvdijen]

I use this; https://github.com/simplesamlphp/saml2/blob/release-4.x/src/SAML2/Utils.php#L311-L357

[robrichards]

@seorefbe Did you see my comment about passing in a reference node and not position? If you modify the code to pass in a reference node rather than position number I would add it in.

[falinhares]

@robrichards I've found a much better solution: so submit to your library only the node that needs the signature and it worked perfectly. Thanks!