Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed installation of yarp_sig header files #3137

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

randaz81
Copy link
Member

Added install of header files generated by thtift in yarp_sig

Copy link

update-docs bot commented Sep 13, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

Copy link

sonarcloud bot commented Sep 13, 2024

@randaz81 randaz81 merged commit 627c4e3 into master Sep 13, 2024
96 of 99 checks passed
@randaz81 randaz81 deleted the fix_yarpsig_install branch September 13, 2024 14:57
Copy link

codacy-production bot commented Sep 13, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+28.12%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9e4dfb7) 538869 140607 26.09%
Head commit (a53da60) 113284 (-425585) 61418 (-79189) 54.22% (+28.12%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3137) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@PeterBowman
Copy link
Member

PeterBowman commented Sep 13, 2024

set_property(TARGET YARP_sig PROPERTY PRIVATE_HEADER ${YARP_sig_IMPL_HDRS})

@randaz81 shouldn't we also install private IDL headers, as in YARP_dev?

set_property(TARGET YARP_sig PROPERTY PRIVATE_HEADER ${YARP_sig_IMPL_HDRS} ${YARP_sig_idl_IMPL_HDRS}) 

@PeterBowman
Copy link
Member

PeterBowman commented Sep 18, 2024

Would it be OK if I open a PR to patch this? It doesn't seem to cause trouble now, but I believe it might explode at some point later, and such tiny things are prone to being hard to debug.

Edit: see #3142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR Type: Bugfix This PR fixes some bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants