fixed dangling pointer using std::string #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in |
randaz81
added
PR Type: Bugfix
Nicogene
previously approved these changes
Jun 4, 2024
randaz81
had a problem deploying
to
code-analysis
GitHub Actions
Failure
randaz81
had a problem deploying
to
code-analysis
GitHub Actions
Failure
randaz81
had a problem deploying
to
code-analysis
GitHub Actions
Failure
randaz81
had a problem deploying
to
code-analysis
GitHub Actions
Failure
randaz81
had a problem deploying
to
code-analysis
GitHub Actions
Failure
randaz81
had a problem deploying
to
code-analysis
GitHub Actions
Failure
randaz81
had a problem deploying
to
code-analysis
GitHub Actions
Failure
randaz81
had a problem deploying
to
code-analysis
GitHub Actions
Failure
|
S-Dafarra
reviewed
Aug 30, 2024
| @@ -569,14 +568,14 @@ const char* YarpBroker::requestRpc(const char* szport, const char* request, doub | |||
| NetworkBase::disconnect(port.getName(), szport); | |||
| if(!response.size() || !ret) { | |||
| port.close(); | |||
| return nullptr; | |||
| return {}; | |||
| } | |||
|
|
|||
| port.close(); | |||
| return response.toString().c_str(); | |||
There was a problem hiding this comment.
Is the c_str() needed here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: #3105
I'm aware that std::string is not a plain char*.
..but do we need to stick to this oooooold '99 style in libyarpmanager? I think not.
BTW, strings are used elsewhere in the same lib.