Fix osqp_vendor dependency in package.xml

[ptenbrock]

When running rosdep install, there is an error regarding the osqp dependency:

ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
osqp-eigen: Cannot locate rosdep definition for [osqp]

[traversaro]

Thanks for reporting the problem @ptenbrock ! The package.xml was added back in time (#109) by @wxmerkt. I think that in his workflow osqp was build as part of the catkin workspace, but probably @wxmerkt can comment on this PR.

[wxmerkt]

I believe this needs to be conditional on the ROS_VERSION variable: osqp for ROS1, osqp_vendor for ROS2.

[traversaro]

I believe this needs to be conditional on the ROS_VERSION variable: osqp for ROS1, osqp_vendor for ROS2.

Can you do this change @ptenbrock ? Thanks!

[ptenbrock]

I checked a few distros, and they all have osqp_vendor as the rosdep-key (I couldn't find osqp/osqp_vendor for melodic):

• noetic: osqp_vendor
• rolling: osqp_vendor
• humble: osqp_vendor
• iron: osqp_vendor

[wxmerkt]

Ok, then this has changed since I set this up something back. Happy to go ahead with the change

[traversaro]

Thanks @wxmerkt and sorry for the radio silence. So it is ok to merge this as it is, that would not be a problem if someone is building osqp+osqp-eigen as part of a catkin or colcon workspace?

[wxmerkt]

@traversaro Yes, good to go ahead.