Reduce excessive logging #1282
Merged
Reduce excessive logging #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # systems/provided/dynamic_small_system_optimise/optimised_positions_stage.py
|
setting as draft until develop lint fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to Python logging has massively increased the number of messages being generated. A lot of messages in the old system were being suppressed by
pst_logger._check_msg_logged_recently_or_update_hash(). The new system doesn't have anything like that, and I don't think it should. Better instead to figure out what was causing the excessive logging, and fix or remove it. This PR deals with some of those cases. It also adds sometime.sleep()calls to continuous algo loops, to reduce load.See this note too