Skip to content

Commit

Permalink
Fix tests and lints (#10)
Browse files Browse the repository at this point in the history
  • Loading branch information
rlex authored Feb 2, 2022
1 parent 49195d7 commit 92e7aa2
Show file tree
Hide file tree
Showing 11 changed files with 23 additions and 24 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/lint-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ jobs:
- name: Set up Helm
uses: azure/setup-helm@v1
with:
version: v3.4.0
version: v3.7.0

- uses: actions/setup-python@v2
with:
python-version: 3.7

- name: Set up chart-testing
uses: helm/chart-testing-action@v2.1.0
uses: helm/chart-testing-action@v2.2.0

- name: Run chart-testing (list-changed)
id: list-changed
Expand All @@ -32,7 +32,7 @@ jobs:
fi
- name: Run chart-testing (lint)
run: ct lint --check-version-increment=false
run: ct lint --check-version-increment=false --chart-repos bitnami=https://charts.bitnami.com/bitnami --validate-maintainers=false --validate-yaml=false

- name: Create kind cluster
uses: helm/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion charts/parca/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.4.0
version: 1.4.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 1 addition & 1 deletion charts/parca/templates/agent-daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ spec:
- --log-level={{ .Values.agent.logLevel }}
- --node=$(NODE_NAME)
- --kubernetes
- --store-address=parca-server.{{ .Release.Namespace }}.svc.cluster.local:7070
- --store-address={{ include "parca.fullname" . }}-server.{{ .Release.Namespace }}.svc.cluster.local:7070
- --insecure
- --insecure-skip-verify
- --temp-dir=/tmp
Expand Down
8 changes: 4 additions & 4 deletions charts/parca/templates/tests/test-connection.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ metadata:
"helm.sh/hook": test
spec:
containers:
- name: wget-agent
- name: wget-server
image: busybox
command: ['wget']
args: ['{{ include "parca.fullname" . }}:{{ .Values.agent.service.port }}']
- name: wget-server
args: ['{{ include "parca.fullname" . }}-server:{{ .Values.server.service.port }}']
- name: wget-agent
image: busybox
command: ['wget']
args: ['{{ include "parca.fullname" . }}:{{ .Values.server.service.port }}']
args: ['{{ include "parca.fullname" . }}-agent:{{ .Values.agent.service.port }}']
restartPolicy: Never
16 changes: 8 additions & 8 deletions charts/parca/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -153,13 +153,13 @@ ingress:

# parca keeps it's TSDB in-memory, so replicas and HPAs are useless.
# That might change in future, so let's keep that stuff comemented out, just in casr
#server.replicaCount: 1
# server.replicaCount: 1

#autoscaling:
# enabled: false
# minReplicas: 1
# maxReplicas: 100
# targetCPUUtilizationPercentage: 80
# targetMemoryUtilizationPercentage: 80
# autoscaling:
# enabled: false
# minReplicas: 1
# maxReplicas: 100
# targetCPUUtilizationPercentage: 80
# targetMemoryUtilizationPercentage: 80

#affinity: {}
# affinity: {}
4 changes: 2 additions & 2 deletions charts/pyrra/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.2
version: 0.1.3

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "v0.2.0"
appVersion: "v0.2.0"
2 changes: 1 addition & 1 deletion charts/pyrra/templates/clusterrole.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ rules:
verbs:
- get
- patch
- update
- update
2 changes: 1 addition & 1 deletion charts/pyrra/templates/clusterrolebinding.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ roleRef:
subjects:
- kind: ServiceAccount
name: {{ include "pyrra.serviceAccountName" . }}
namespace: {{ .Release.Namespace }}
namespace: {{ .Release.Namespace }}
2 changes: 1 addition & 1 deletion charts/pyrra/templates/servicemonitor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ spec:
relabelings:
{{ toYaml .Values.serviceMonitor.relabelings | indent 4 }}
{{- end }}
{{- end }}
{{- end }}
1 change: 0 additions & 1 deletion charts/pyrra/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,4 +76,3 @@ tolerations: {}
serviceMonitor:
# -- enables servicemonitor for server monitoring
enabled: false

2 changes: 1 addition & 1 deletion charts/yopass/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ home: https://github.com/jhaals/yopass
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.4.0
version: 0.4.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down

0 comments on commit 92e7aa2

Please sign in to comment.