Add genericRules support for pyrra (#90)

* Add genericRules support for pyrra * Update README.md * Update README.md * Fix typo in chart.yml * Fix readme --------- Co-authored-by: Lex Rivera <[email protected]>
rlex · Feb 24, 2023 · 4b956ff · 4b956ff
1 parent 6809dd0
commit 4b956ff
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/charts/pyrra/Chart.yaml b/charts/pyrra/Chart.yaml
@@ -15,7 +15,8 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.4.1
+
+version: 0.4.2
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to

diff --git a/charts/pyrra/README.md b/charts/pyrra/README.md
@@ -1,6 +1,6 @@
 # pyrra
 
-![Version: 0.4.1](https://img.shields.io/badge/Version-0.4.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.5.1](https://img.shields.io/badge/AppVersion-v0.5.1-informational?style=flat-square)
+![Version: 0.4.2](https://img.shields.io/badge/Version-0.4.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.5.1](https://img.shields.io/badge/AppVersion-v0.5.1-informational?style=flat-square)
 
 SLO manager and alert generator
 
@@ -13,6 +13,7 @@ Additionaly, you (most likely) will need to specify prometheusExternalUrl with U
 | Key | Type | Default | Description |
 |-----|------|---------|-------------|
 | fullnameOverride | string | `""` | Overrides helm-generated chart fullname |
+| genericRules.enabled | boolean | `false` | Generats Pyrra generic recording rules |
 | image.pullPolicy | string | `"IfNotPresent"` | Overrides pullpolicy |
 | image.repository | string | `"ghcr.io/pyrra-dev/pyrra"` | Overrides the image repository |
 | image.tag | string | `"v0.5.1"` | Overrides the image tag |
@@ -43,4 +44,4 @@ Additionaly, you (most likely) will need to specify prometheusExternalUrl with U
 
 ## Upgrading
 
-A major chart version change indicates that there is an incompatible breaking change needing manual actions.
+A major chart version change indicates that there is an incompatible breaking change needing manual actions.
diff --git a/charts/pyrra/templates/deployment.yaml b/charts/pyrra/templates/deployment.yaml
@@ -32,6 +32,9 @@ spec:
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           args:
             - kubernetes
+            {{- if .Values.genericRules.enabled }}
+            - --generic-rules
+            {{- end }}
           resources:
             {{- toYaml .Values.resources | nindent 12 }}
         - name: {{ .Chart.Name }}

diff --git a/charts/pyrra/values.yaml b/charts/pyrra/values.yaml
@@ -80,3 +80,7 @@ tolerations: {}
 serviceMonitor:
   # -- enables servicemonitor for server monitoring
   enabled: false
+
+genericRules: 
+  # -- enables generate Pyrra generic recording rules. Pyrra generates metrics with the same name for each SLO.
+  enabled: false