Skip to content

Commit

Permalink
feat(pyrra): added extraKubernetesArgs and extraApiArgs (#129)
Browse files Browse the repository at this point in the history
* feat(pyrra): added extraKubernetesArgs and extraApiArgs

Signed-off-by: David Calvert <[email protected]>

* doc(pyrra): updated README.md

Signed-off-by: David Calvert <[email protected]>

* fix(doc): new options descriptions

Signed-off-by: David Calvert <[email protected]>

---------

Signed-off-by: David Calvert <[email protected]>
  • Loading branch information
dotdc authored Sep 18, 2023
1 parent a7c223e commit 0723a47
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 3 deletions.
4 changes: 2 additions & 2 deletions charts/pyrra/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ type: application
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)

version: 0.8.0
version: 0.9.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: v0.6.2
appVersion: v0.6.4
4 changes: 3 additions & 1 deletion charts/pyrra/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# pyrra

![Version: 0.8.0](https://img.shields.io/badge/Version-0.8.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.6.2](https://img.shields.io/badge/AppVersion-v0.6.2-informational?style=flat-square)
![Version: 0.9.0](https://img.shields.io/badge/Version-0.9.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.6.4](https://img.shields.io/badge/AppVersion-v0.6.4-informational?style=flat-square)

SLO manager and alert generator

Expand All @@ -13,6 +13,8 @@ Additionaly, you (most likely) will need to specify prometheusExternalUrl with U
| Key | Type | Default | Description |
|-----|------|---------|-------------|
| additionalLabels | object | `{}` | |
| extraApiArgs | list | `[]` | Extra args for Pyrra's API container |
| extraKubernetesArgs | list | `[]` | Extra args for Pyrra's Kubernetes container |
| fullnameOverride | string | `""` | Overrides helm-generated chart fullname |
| genericRules.enabled | bool | `false` | enables generate Pyrra generic recording rules. Pyrra generates metrics with the same name for each SLO. |
| image.pullPolicy | string | `"IfNotPresent"` | Overrides pullpolicy |
Expand Down
6 changes: 6 additions & 0 deletions charts/pyrra/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ spec:
{{- if .Values.genericRules.enabled }}
- --generic-rules
{{- end }}
{{- with .Values.extraKubernetesArgs }}
{{- toYaml . | nindent 12 }}
{{- end }}
resources:
{{- toYaml .Values.resources | nindent 12 }}
- name: {{ .Chart.Name }}
Expand All @@ -49,6 +52,9 @@ spec:
{{- if .Values.prometheusExternalUrl }}
- --prometheus-external-url={{ .Values.prometheusExternalUrl }}
{{- end }}
{{- with .Values.extraApiArgs }}
{{- toYaml . | nindent 12 }}
{{- end }}
ports:
- name: http
containerPort: 9099
Expand Down
5 changes: 5 additions & 0 deletions charts/pyrra/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ image:
additionalLabels: {}
# app: pyrra

# -- Extra args for Pyrra's API container
extraApiArgs: []
# -- Extra args for Pyrra's Kubernetes container
extraKubernetesArgs: []

serviceAccount:
# -- Specifies whether a service account should be created
create: true
Expand Down

0 comments on commit 0723a47

Please sign in to comment.