Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidate mnemonic field to fix double frees and other funny stuff. #4713

Closed
wants to merge 1 commit into from
Closed

Invalidate mnemonic field to fix double frees and other funny stuff. #4713

wants to merge 1 commit into from

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Nov 11, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

...

@Rot127 Rot127 requested a review from wargio as a code owner November 11, 2024 16:18
XVilka
XVilka reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RZ_FREE() should do just that, IIRC.

@Rot127
Copy link
Member Author

Rot127 commented Nov 11, 2024

Ah nice. It does. The double free happened for another reason anyways.

@Rot127 Rot127 closed this Nov 11, 2024
@Rot127 Rot127 deleted the invalidate-mnem branch November 11, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka left review comments

@wargio wargio Awaiting requested review from wargio wargio is a code owner

Assignees
No one assigned
Labels
RzAnalysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rot127 @XVilka