-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix meson-build global_arguments #4698
Conversation
6d82baa
to
84398aa
Compare
99f8713
to
93b6425
Compare
93b6425
to
f1a7a18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add the changes to the test and i think is ok to merge
Could you be more specific which test do you mean? The standard |
637811d
to
da76065
Compare
i was exactly referring to the changes that you have pushed. |
3154937
to
8a6137e
Compare
Branch squashed and rebased |
* Added a CI-task to check if rizin could be used as subproject * Fixed some new global-arguments in meson-build
8a6137e
to
1f74daf
Compare
Your checklist for this pull request
Detailed description
It happened again...
This makes it (again) impossible to add rizin as subproject.
Test plan
To avoid any further regressions, a CI-Task is proposed herein.
The task really just tests if it is possible to use a branch/PR of rizin as subproject. It (currently) wouldn't check for any linker-problems or API-stability as there is no such guaranty in that setup.
Closing issues
Partially addresses #3454
Also: