Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix meson-build global_arguments #4698

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

amibranch
Copy link
Contributor

@amibranch amibranch commented Nov 3, 2024

  • Added a CI-task to check if rizin could be used as subproject
  • Fixed some new global-arguments in meson-build

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

It happened again...

This makes it (again) impossible to add rizin as subproject.

Test plan

To avoid any further regressions, a CI-Task is proposed herein.

The task really just tests if it is possible to use a branch/PR of rizin as subproject. It (currently) wouldn't check for any linker-problems or API-stability as there is no such guaranty in that setup.

Closing issues

Partially addresses #3454

Also:

  • The integration tests will be excluded herein, if rizins CLI is disabled by build-configuration. In this case no rizin-binary is available that could be used for the Integration-tests.

@amibranch amibranch force-pushed the dist-add_subproject_test branch 2 times, most recently from 6d82baa to 84398aa Compare November 3, 2024 19:40
@amibranch amibranch marked this pull request as draft November 3, 2024 19:41
@amibranch amibranch force-pushed the dist-add_subproject_test branch 10 times, most recently from 99f8713 to 93b6425 Compare November 3, 2024 21:13
@amibranch amibranch marked this pull request as ready for review November 3, 2024 21:32
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add the changes to the test and i think is ok to merge

@amibranch
Copy link
Contributor Author

Just add the changes to the test and i think is ok to merge

Could you be more specific which test do you mean? The standard CI-tasks?

@amibranch amibranch force-pushed the dist-add_subproject_test branch 2 times, most recently from 637811d to da76065 Compare November 6, 2024 16:11
@wargio
Copy link
Member

wargio commented Nov 7, 2024

Just add the changes to the test and i think is ok to merge

Could you be more specific which test do you mean? The standard CI-tasks?

i was exactly referring to the changes that you have pushed.

@amibranch
Copy link
Contributor Author

Branch squashed and rebased

* Added a CI-task to check if rizin could be used as subproject
* Fixed some new global-arguments in meson-build
@XVilka XVilka requested a review from wargio November 11, 2024 07:30
@XVilka XVilka merged commit 70654e8 into rizinorg:dev Nov 11, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants