Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rizin as subproject [rebased] #4680

Closed
wants to merge 4 commits into from

Conversation

amibranch
Copy link
Contributor

@amibranch amibranch commented Oct 19, 2024

DRAFT*

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This is just a rebased version of:
#4679
#3706

This PR was created for checking the CI only!

...

Test plan

...

Closing issues

...

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capstone build also fails with pure C99:

FAILED: subprojects/capstone-next/libcapstone.a.p/cs.c.o 
gcc-12 -Isubprojects/capstone-next/libcapstone.a.p -I../subprojects/capstone-next/include -I../subprojects/capstone-next/include/capstone -fdiagnostics-color=always -fsanitize=address,undefined -fno-omit-frame-pointer -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -std=c99 -O2 -g -DASAN=1 -DRZ_ASSERT_STDOUT=1 -Wno-cpp -ftrivial-auto-var-init=pattern -funsigned-char -fPIC -DCAPSTONE_X86_ATT_DISABLE_NO -DCAPSTONE_X86_REDUCE_NO -DCAPSTONE_USE_SYS_DYN_MEM -DCAPSTONE_DIET_NO -DCAPSTONE_HAS_ALPHA -DCAPSTONE_HAS_ARM -DCAPSTONE_HAS_AARCH64 -DCAPSTONE_HAS_HPPA -DCAPSTONE_HAS_M68K -DCAPSTONE_HAS_M680X -DCAPSTONE_HAS_MIPS -DCAPSTONE_HAS_POWERPC -DCAPSTONE_HAS_SPARC -DCAPSTONE_HAS_SYSZ -DCAPSTONE_HAS_X86 -DCAPSTONE_HAS_XCORE -DCAPSTONE_HAS_TMS320C64X -DCAPSTONE_HAS_TRICORE -Wno-maybe-uninitialized -MD -MQ subprojects/capstone-next/libcapstone.a.p/cs.c.o -MF subprojects/capstone-next/libcapstone.a.p/cs.c.o.d -o subprojects/capstone-next/libcapstone.a.p/cs.c.o -c ../subprojects/capstone-next/cs.c
../subprojects/capstone-next/cs.c: In function ‘fill_insn’:
../subprojects/capstone-next/cs.c:867:47: error: ‘__builtin_strncpy’ output may be truncated copying 31 bytes from a string of length 31 [-Werror=stringop-truncation]
  867 |                                         (void)strncpy(insn->mnemonic, str, sizeof(insn->mnemonic) - 1);
      |                                               ^
cc1: all warnings being treated as errors

cc @Rot127

@amibranch amibranch mentioned this pull request Oct 19, 2024
5 tasks
@amibranch amibranch changed the title Rizin as subproject [rebased version] Rizin as subproject [rebased] Oct 19, 2024
@amibranch amibranch force-pushed the rizin_as_subproject_rebase branch 4 times, most recently from 7719554 to 9017f9d Compare October 20, 2024 19:24
Also removed an arg that is not allowed in muon and ignored by meson
@wargio
Copy link
Member

wargio commented Oct 21, 2024

why there are 2 branches with the same code? just use one PR and rebase within it.

@wargio wargio closed this Oct 21, 2024
@amibranch amibranch mentioned this pull request Oct 22, 2024
5 tasks
@amibranch amibranch deleted the rizin_as_subproject_rebase branch November 3, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants