-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rizin as subproject [rebased] #4680
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amibranch
requested review from
yossizap,
ret2libc,
wargio,
XVilka,
kazarmy and
thestr4ng3r
as code owners
October 19, 2024 13:57
XVilka
requested changes
Oct 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capstone build also fails with pure C99:
FAILED: subprojects/capstone-next/libcapstone.a.p/cs.c.o
gcc-12 -Isubprojects/capstone-next/libcapstone.a.p -I../subprojects/capstone-next/include -I../subprojects/capstone-next/include/capstone -fdiagnostics-color=always -fsanitize=address,undefined -fno-omit-frame-pointer -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -std=c99 -O2 -g -DASAN=1 -DRZ_ASSERT_STDOUT=1 -Wno-cpp -ftrivial-auto-var-init=pattern -funsigned-char -fPIC -DCAPSTONE_X86_ATT_DISABLE_NO -DCAPSTONE_X86_REDUCE_NO -DCAPSTONE_USE_SYS_DYN_MEM -DCAPSTONE_DIET_NO -DCAPSTONE_HAS_ALPHA -DCAPSTONE_HAS_ARM -DCAPSTONE_HAS_AARCH64 -DCAPSTONE_HAS_HPPA -DCAPSTONE_HAS_M68K -DCAPSTONE_HAS_M680X -DCAPSTONE_HAS_MIPS -DCAPSTONE_HAS_POWERPC -DCAPSTONE_HAS_SPARC -DCAPSTONE_HAS_SYSZ -DCAPSTONE_HAS_X86 -DCAPSTONE_HAS_XCORE -DCAPSTONE_HAS_TMS320C64X -DCAPSTONE_HAS_TRICORE -Wno-maybe-uninitialized -MD -MQ subprojects/capstone-next/libcapstone.a.p/cs.c.o -MF subprojects/capstone-next/libcapstone.a.p/cs.c.o.d -o subprojects/capstone-next/libcapstone.a.p/cs.c.o -c ../subprojects/capstone-next/cs.c
../subprojects/capstone-next/cs.c: In function ‘fill_insn’:
../subprojects/capstone-next/cs.c:867:47: error: ‘__builtin_strncpy’ output may be truncated copying 31 bytes from a string of length 31 [-Werror=stringop-truncation]
867 | (void)strncpy(insn->mnemonic, str, sizeof(insn->mnemonic) - 1);
| ^
cc1: all warnings being treated as errors
cc @Rot127
amibranch
force-pushed
the
rizin_as_subproject_rebase
branch
from
October 19, 2024 18:14
c33173e
to
4de58d6
Compare
amibranch
changed the title
Rizin as subproject [rebased version]
Rizin as subproject [rebased]
Oct 19, 2024
amibranch
force-pushed
the
rizin_as_subproject_rebase
branch
4 times, most recently
from
October 20, 2024 19:24
7719554
to
9017f9d
Compare
Also removed an arg that is not allowed in muon and ignored by meson
amibranch
force-pushed
the
rizin_as_subproject_rebase
branch
from
October 20, 2024 19:47
9017f9d
to
d447870
Compare
why there are 2 branches with the same code? just use one PR and rebase within it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT*
Your checklist for this pull request
Detailed description
This is just a rebased version of:
#4679
#3706
This PR was created for checking the CI only!
...
Test plan
...
Closing issues
...