Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare dk 9 test broken #4653

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Declare dk 9 test broken #4653

merged 1 commit into from
Sep 27, 2024

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Sep 27, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr declares the dk 9 test as broken because of the possibility of trying to dc a binary that already been terminated (as shown in #4652 (comment)) -- basically the test needs the ability to handle 2 different situations. This pr also removes some unneeded code, reverting #4650.

Test plan

The declaration and removal of code are appropriate.

Closing issues

...

@kazarmy kazarmy merged commit 3fcfdd5 into rizinorg:dev Sep 27, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants