Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose APIs for rz-solver #4648

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

Expose APIs for rz-solver #4648

wants to merge 6 commits into from
+184 −126

Conversation

giridharprasath
Copy link
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Exposing some APIs required for rz-solver
#4563

...

Test plan

...

Closing issues

...

XVilka
XVilka requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend writing a unit test for these ROP APIs, it will certainly help with the development and automated testing.

librz/core/cmd/cmd_search_rop.c Show resolved Hide resolved
librz/core/rop.c Outdated Show resolved Hide resolved
@giridharprasath
Copy link
Contributor Author

I recommend writing a unit test for these ROP APIs, it will certainly help with the development and automated testing.

Agree 👍 , Will track it under another issue

@giridharprasath
Copy link
Contributor Author

APIs used by the rz-solver: test-rop-solver.c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka requested changes

@wargio wargio Awaiting requested review from wargio wargio will be requested when the pull request is marked ready for review wargio is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy will be requested when the pull request is marked ready for review kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r will be requested when the pull request is marked ready for review thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc will be requested when the pull request is marked ready for review ret2libc is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
API panel RzCore visual
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giridharprasath @XVilka