Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change permissions of some tests to 0644 from 0755 #4636

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Sep 18, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr changes the permissions of db/asm/arm_16 and db/analysis/thumb to 0644 since they don't need to be executable.

Test plan

The new permissions are appropriate.

Closing issues

...

@wargio
Copy link
Member

wargio commented Sep 18, 2024

is this the only one that has wrong perms ?

@wargio
Copy link
Member

wargio commented Sep 18, 2024

i have just checked and also ./db/analysis/thumb has wrong perms, could you change also this one?
i used find \! -perm 644 -type f -o \! -perm 755 -type d

@kazarmy
Copy link
Member Author

kazarmy commented Sep 18, 2024

i have just checked and also ./db/analysis/thumb has wrong perms, could you change also this one?

Sure! bf86fa7

@kazarmy kazarmy changed the title Change permissions of db/asm/arm_16 to 0644 Change permissions of some tests to 0644 to 0755 Sep 18, 2024
@kazarmy
Copy link
Member Author

kazarmy commented Sep 18, 2024

i used find \! -perm 644 -type f -o \! -perm 755 -type d

ls -laR | grep -C3 rwx works too but the above works better

@kazarmy kazarmy changed the title Change permissions of some tests to 0644 to 0755 Change permissions of some tests to 0644 from 0755 Sep 18, 2024
@wargio wargio merged commit 81cad7d into rizinorg:dev Sep 18, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants