RzTable API Refactoring
#4625
Merged
RzTable API Refactoring
#4625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brightprogrammer instead of waiting when all of the issue is covered, I recommend just doing it piece-by-piece, and merge this as is. Please rebase and mark as ready for the review. |
|
Ok |
For cases when we need to directly use arguments of a variadic function to add a new row to `RzTable`, the new `rz_table_add_vrowf` will take a `va_list` and a format string to do the same.
brightprogrammer
force-pushed
the
rztable_refactor
branch
from
9d82c3a
to
a23d6d1
Compare
|
Running |
brightprogrammer
requested review from
ret2libc,
thestr4ng3r,
wargio,
XVilka and
kazarmy
as code owners
wargio
approved these changes
Sep 18, 2024
ensure you run clang-format16 (you can supply the clang format bin path by cmd line to the python script) |
brightprogrammer
added a commit
to RevEngAI/reai-rz
that referenced
this pull request
Sep 18, 2024
The commit refactors and fixes the table generation bugs in `ReaiPluginTable` abstraction. The plugin now completely uses the API provided by `RzTable` to generate the table and display it. This was possible because of recent merge of PR rizinorg/rizin#4625 This also means that users might face some problems if they use a release version of Rizin/Cutter. Users (for now) must build Rizin from source until unless a new version of Rizin is released with the changes in PR present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
RzTableAPI refactoring.TODOs for this PR :
RzTablefromRzListto either vectors or hashtable (HtPPor something like that) : This is already addressed by Refactor RzTable: change the internal storage to RzVector #2421 and Refactor RzTable: change the implementation to RzVector #2536This PR also adds a new function to
RzTableAPI for adding a new row using a format string and ava_list.Test plan
N/A
Closing issues
#1961