Add MS-DOS and Win32 Timestamp Conversion to rz-ax #4526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This adds MS-DOS and Win32 timestamp conversions in the
rz-ax
util / command. These have been added as flag-m
and-W
respectively. The relevant help / print statements have been edited. Givenrz_time_stamp_is_dos_format
is in the codebase, we can "guess" if the timestamp is MS-DOS or Unix, so it may be better to have that all under the-t
command, but I don't know if that's a good plan. Would like feedback from the maintainers on everything.I didn't see any appropriate place in the rizin book for this, but I did update the help command for
rz-ax
with the new field and confirmed it shows up.Test plan
As long as the
rz_time_date_dos_to_string
function is tested, this can be considered tested. I did not see any tests explicitly testing the-t
command in the test database.Closing issues
closes #4515