Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MS-DOS and Win32 Timestamp Conversion to rz-ax #4526

Merged
merged 4 commits into from
Jun 2, 2024

Conversation

TheN00bBuilder
Copy link
Contributor

@TheN00bBuilder TheN00bBuilder commented Jun 2, 2024

Your checklist for this pull request

  • [v] I've read the guidelines for contributing to this repository
  • [v] I made sure to follow the project's coding style
  • [v] I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • [v] I've added tests that prove my fix is effective or that my feature works (if possible)
  • [?] I've updated the rizin book with the relevant information (if needed)

Detailed description

This adds MS-DOS and Win32 timestamp conversions in the rz-ax util / command. These have been added as flag -m and -W respectively. The relevant help / print statements have been edited. Given rz_time_stamp_is_dos_format is in the codebase, we can "guess" if the timestamp is MS-DOS or Unix, so it may be better to have that all under the -t command, but I don't know if that's a good plan. Would like feedback from the maintainers on everything.

I didn't see any appropriate place in the rizin book for this, but I did update the help command for rz-ax with the new field and confirmed it shows up.

Test plan

As long as the rz_time_date_dos_to_string function is tested, this can be considered tested. I did not see any tests explicitly testing the -t command in the test database.

added_cmd_and_output

Closing issues

closes #4515

@github-actions github-actions bot added the rz-ax label Jun 2, 2024
@TheN00bBuilder TheN00bBuilder changed the title Add MS-Dos Add MS-DOS Timestamp Conversion to rz-ax Jun 2, 2024
@TheN00bBuilder
Copy link
Contributor Author

D'oh - just realized that MS-DOS timestamps are different from Win32. Adding Win32 now.

@TheN00bBuilder
Copy link
Contributor Author

There we are. Here's the updated command output.
updated_cmd_for_all_cmds

@TheN00bBuilder TheN00bBuilder changed the title Add MS-DOS Timestamp Conversion to rz-ax Add MS-DOS and Win32 Timestamp Conversion to rz-ax Jun 2, 2024
@XVilka XVilka merged commit 53ce6e5 into rizinorg:dev Jun 2, 2024
44 checks passed
@XVilka
Copy link
Member

XVilka commented Jun 2, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose DOS and Win32 timestamps encoding/decoding in rz-ax.
2 participants