[MSP430] Removed code which deletes indicator characters for certain asm syntaxes #4522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This should fix issue #3324 in Cutter's bug log.
...
Test plan
I have searched in the git history and tracked the introduction of the deleted code to commit hash c83d5f4664f222f318f8e4ae3910aeb9e5515902, I have tried to find any PR or detailed message associated with this hash, explaining why the code was needed, but I found none, the commit was probably added sometimes in the project's pre-history (back when it was radare2).
As far as I can see, the deleted code has no other effect or purpose except the undesirable effect of deleting indicator characters from the disassembly when the asm syntax isn't AT&T. Any tests breaking due to the removal of this code are wrong tests that should be removed as well.
To verify
Run
rz-asm -a msp430 -d 3f401000
on dev and then on this PR's branch. On dev, it producesmov 0x0010, r15
as output, which is wrong, the correct output should include the character '#' before the constant, as it appears on this PR's branch.