Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tricore: lift remaining floating point instructions #4514

Merged
merged 24 commits into from
Jun 3, 2024
Merged

tricore: lift remaining floating point instructions #4514

merged 24 commits into from
Jun 3, 2024

Conversation

imbillow
Copy link
Contributor

@imbillow imbillow commented May 24, 2024 •
edited by XVilka
Loading

SQUASH ME

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

closes #4115

@imbillow imbillow requested a review from wargio as a code owner May 24, 2024 09:57
@imbillow imbillow marked this pull request as draft May 24, 2024 09:57
@imbillow imbillow marked this pull request as ready for review May 31, 2024 21:04
XVilka
XVilka requested changes Jun 1, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job, as usual! Please add a floating-point Tricore "emulateme" test

librz/arch/isa/tricore/tricore_il_fp.inc Show resolved Hide resolved
librz/arch/isa/tricore/tricore_il_fp.inc Show resolved Hide resolved
librz/include/rz_il/rz_il_opbuilder_begin.h Show resolved Hide resolved
librz/arch/p/analysis/analysis_tricore_cs.c Outdated Show resolved Hide resolved
XVilka
XVilka requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor problem

librz/include/rz_il/rz_il_opbuilder_end.h Outdated Show resolved Hide resolved
@XVilka XVilka changed the title tricore: unlifted floating point instructions tricore: lift remaining floating point instructions Jun 3, 2024
@XVilka XVilka merged commit 255f6fd into dev Jun 3, 2024
45 of 47 checks passed
@XVilka XVilka deleted the rzil-tricore-fp branch June 3, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMaroo DMaroo DMaroo left review comments

@XVilka XVilka XVilka approved these changes

@wargio wargio Awaiting requested review from wargio wargio is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
API ESIL merge-when-green rz-test RzAnalysis RzCore RZIL TriCore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tricore: unlifted floating point instructions
4 participants
@imbillow @XVilka @wargio @DMaroo