Implement one line foreach macros for hash tables.
#4500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rot127
requested review from
ret2libc,
thestr4ng3r,
XVilka,
wargio,
yossizap and
kazarmy
as code owners
The file only contains tests for the hash table. Hence the name change.
XVilka
approved these changes
May 18, 2024
|
@Rot127 one bindgen linter error: |
pelijah
requested changes
May 18, 2024
| /** | ||
| * \brief Foreach iterator over a RzSetS. The set elements can be accessed via \p it->kv.key. | ||
| */ | ||
| #define rz_set_s_foreach(s, it) ht_foreach (sp, s, it) |
There was a problem hiding this comment.
Accessing elements of sets via it->kv.key is not user friendly. User is not supposed to know about internals of RzSetS.
const char *elem;
rz_set_s_foreach(s, it, elem) { ... }You will have to use modified ht_foreach body to implement this.
pelijah
reviewed
May 19, 2024
|
|
||
| #define ht_foreach(type, ht, iter) \ | ||
| if (ht && ht_##type##_size(ht) > 0) \ | ||
| for (iter.ti = 0, iter.bi = 0, iter.kv = NULL, ht_##type##_advance_iter(ht, &iter); iter.kv != NULL; ht_##type##_advance_iter(ht, &iter)) |
There was a problem hiding this comment.
IMO it would be preferable to have more standard iterator API with first()/next()
For example loop statement could look like:
for (iter = Ht_(iter_first)(ht) /*As I see it is ok to return struct from API*/; iter.kv != NULL; Ht_(iter_next)(ht, &iter))
There was a problem hiding this comment.
Yes, makes sense. Check also:
librz/util/iterator.clibrz/include/rz_util/rz_iterator.h
There was a problem hiding this comment.
At this point we could also just add a RzIterator *ht_xx_as_iter();, right?
Otherwise, we just duplicate the API from iterators to hash tables.
|
Please rebase. |
5 tasks
|
Superseded by #4639 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Adds one line
foreachmacros for hash tables and in extend sets.Additionally:
for eachmechanism toht_foreach_cb(cbforcall back), so they can be distinguished.ht_xx_size()function for simpler access to theht->countmember.test_sdb_hash.ctotest_ht.c. Because it was hard to find before with a search.Test plan
Tests added.
Closing issues
...