Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SdbList #4496

Merged
merged 4 commits into from
May 17, 2024
Merged

Remove SdbList #4496

merged 4 commits into from
May 17, 2024

Conversation

pelijah
Copy link
Contributor

@pelijah pelijah commented May 16, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

...

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!
rz-bindgen linter problem though:

Run python3 rz-bindgen/src/lint.py \
Type comment at <rizin/librz/util/sdb/src/text.c:226:23> lacks pointer
Error: Process completed with exit code 1.

@pelijah
Copy link
Contributor Author

pelijah commented May 17, 2024

Nice cleanup! rz-bindgen linter problem though:

Run python3 rz-bindgen/src/lint.py \
Type comment at <rizin/librz/util/sdb/src/text.c:226:23> lacks pointer
Error: Process completed with exit code 1.

I didn't touch that code

librz/util/sdb/src/text.c Outdated Show resolved Hide resolved
XVilka

This comment was marked as resolved.

@XVilka XVilka merged commit 9c34738 into rizinorg:dev May 17, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants