Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dbg_dmh test due to CI ubuntu-22.04 image 20240514.2.0 #4495

Merged
merged 1 commit into from
May 16, 2024

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented May 16, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

I can repro the dbh_dmh failure in #4493 locally (the dbg_dmht failure appears to be transient). Size changes are consistent and appear reasonable.

Test plan

All builds are green.

Closing issues

Closes #4493.

@kazarmy kazarmy changed the title Fix dbg_dmh test based on libc6 2.35-0ubuntu3.7 Fix dbg_dmh test due to CI ubuntu-22.04 image 20240514.2.0 May 16, 2024
@kazarmy
Copy link
Member Author

kazarmy commented May 16, 2024

Sorry, there has been an ubuntu-22.04 image bump today to 20240514.2 but the libc package used is apparently the same. I have updated the pr title and description.

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if green

@XVilka XVilka merged commit a6d4a6b into rizinorg:dev May 16, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix heap tests on CI - updated Linux?
2 participants