Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bin_elf import & symbol leak #4490

Merged
merged 9 commits into from
May 18, 2024
Merged

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented May 13, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr fixes the bin_elf import and symbol leak.

Test plan

All builds are green.

Closing issues

...

@github-actions github-actions bot removed the PE label May 16, 2024
@github-actions github-actions bot added ELF and removed rz-test labels May 18, 2024
@kazarmy kazarmy marked this pull request as ready for review May 18, 2024 10:44
@kazarmy
Copy link
Member Author

kazarmy commented May 18, 2024

The original code doesn't do any freeing in rz_bin_reloc_free() -- the pr code does, and so despite the leaks this pr is an improvement.

Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as it doesn't double free, it is ok for me

@kazarmy kazarmy merged commit c082ae8 into rizinorg:dev May 18, 2024
44 checks passed
@XVilka
Copy link
Member

XVilka commented May 18, 2024

@kazarmy kazarmy mentioned this pull request May 18, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants