Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extended insert/update methods for HT #4489

Merged
merged 11 commits into from
May 17, 2024
Merged

Add extended insert/update methods for HT #4489

merged 11 commits into from
May 17, 2024

Conversation

pelijah
Copy link
Contributor

@pelijah pelijah commented May 12, 2024 •
edited
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

HT insert/update methods don't provide information about what really happened: was KV inserted/updated or existing KV prevented insertion. In result it requires to do extra requests to a HT.

pelijah
pelijah commented May 12, 2024
View reviewed changes
librz/util/str_constpool.c Outdated Show resolved Hide resolved
XVilka
XVilka requested changes May 12, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea and nice finding! Looking at the code, it might help a bit with speeding up big debuginfo parsing: #4386

cc @imbillow @rockrid3r @Rot127

librz/include/rz_util/ht_inc.h Outdated Show resolved Hide resolved
@pelijah

This comment was marked as outdated.

Sign in to view
@pelijah pelijah marked this pull request as ready for review May 15, 2024 20:08
@pelijah pelijah changed the title Return more info from HT insert/update methods Add extended insert/update methods for HT May 15, 2024
@XVilka XVilka merged commit 0120350 into rizinorg:dev May 17, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio left review comments

@XVilka XVilka XVilka approved these changes

@imbillow imbillow imbillow approved these changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

Assignees
No one assigned
Labels
API rz-test RzUtil
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pelijah @imbillow @XVilka @wargio