Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor rz_core_theme_list() to return RzPVector #4486

Merged
merged 4 commits into from
May 12, 2024
Merged

Refactor rz_core_theme_list() to return RzPVector #4486

merged 4 commits into from
May 12, 2024

Conversation

pelijah
Copy link
Contributor

@pelijah pelijah commented May 11, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

...

XVilka
XVilka requested changes May 12, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the function name

librz/core/cmd/cmd_eval.c Outdated Show resolved Hide resolved
wargio
wargio reviewed May 12, 2024
View reviewed changes
librz/core/cmd/cmd_eval.c Outdated Show resolved Hide resolved
wargio
wargio reviewed May 12, 2024
View reviewed changes
librz/core/cmd/cmd_eval.c Outdated Show resolved Hide resolved
wargio
wargio reviewed May 12, 2024
View reviewed changes
librz/core/cmd/cmd_eval.c Outdated Show resolved Hide resolved
@XVilka XVilka merged commit e922185 into rizinorg:dev May 12, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio left review comments

@XVilka XVilka XVilka approved these changes

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
API panel RzCore visual
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pelijah @XVilka @wargio