Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/canalysis.c: fix the ignored parameter in rz_core_analysis_function_signature_editor #4481

Merged
merged 1 commit into from
May 9, 2024

Conversation

PeiweiHu
Copy link
Contributor

@PeiweiHu PeiweiHu commented May 9, 2024

The key s doesn't work properly in Vv mode. Even if we change selected functions by j and k, the shown function signature doesn't change.

It seems that rz_core_analysis_function_signature_editor forgets to use the parameter addr.

sig.mp4

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

...

@wargio wargio merged commit 416fc1e into rizinorg:dev May 9, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants