-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor sdb_foreach and related APIs #4471
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelijah
requested review from
ret2libc,
thestr4ng3r,
XVilka,
wargio,
yossizap and
kazarmy
as code owners
May 5, 2024 08:48
This comment has been minimized.
This comment has been minimized.
wargio
approved these changes
May 5, 2024
XVilka
requested changes
May 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but needs minor renaming
XVilka
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
sdb_dump_dupnext()
was replaced withsdb_dump_next()
which returns pointers to mmaped/buffered file (sdb_const_get()
already does the same thing)sdb_dump_next()
reads KV until start of hashes table is reachedsdb_foreach()
now passeskey/value lengthesSdbKv
to a callbacksdb_foreach_list*()
APIs were replaced withsdb_get_kv_list*()
which returnRzList
sdb_get_items*()
which returnRzPVector
instead ofSdbList
(it is the first step of getting rid ofSdbList
)Test plan
...
Closing issues
...