Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debuginfod test timeout under -q #4470

Merged
merged 1 commit into from
May 5, 2024

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented May 4, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr fixes the following debuginfod test timeout under -q (https://github.com/rizinorg/rizin/actions/runs/8939137806/job/24554607466?pr=4468#step:19:4628). Apparently if Rizin tasks are used, the debuginfod task sleeps and never wakes up even with the kill:

debuginfod-timeout

This is a cherry-pick from #4468.

Test plan

All builds are green.

Closing issues

...

@XVilka
Copy link
Member

XVilka commented May 5, 2024

Though it just probably means the bug in the tasks code somewhere

@kazarmy
Copy link
Member Author

kazarmy commented May 5, 2024

Perhaps but not entirely sure whether the fix is simple or complicated, since the tasks code needs to be notified somehow that the debuginfod process has terminated, yet Rizin tasks isn't just about spawning processes via !

@kazarmy kazarmy merged commit e283bda into rizinorg:dev May 5, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants