RzIL: add aezsue to support Step until PC equals given address and output VM changes
#4466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbillow
requested review from
wargio,
XVilka,
kazarmy,
thestr4ng3r and
ret2libc
as code owners
pelijah
reviewed
Apr 30, 2024
pelijah
reviewed
Apr 30, 2024
pelijah
requested changes
Apr 30, 2024
… output VM changes`
wargio
reviewed
May 1, 2024
librz/arch/il/analysis_il.c
Outdated
Comment on lines
319
to
321
| RZ_API RzAnalysisILStepResult rz_analysis_il_vm_step_while( | ||
| RZ_NONNULL RzAnalysis *analysis, RZ_NONNULL RzAnalysisILVM *vm, RZ_NULLABLE RzReg *reg, | ||
| RZ_NONNULL cond_callback cond, RZ_NULLABLE void *user) { |
There was a problem hiding this comment.
If cond_callback is used in the RZ_API then is worth moving it with a proper name into the header.
pelijah
reviewed
May 1, 2024
| RzAnalysisILStepResult res = RZ_ANALYSIS_IL_STEP_RESULT_SUCCESS; | ||
| while (cond(vm, user)) { | ||
| ut64 addr = rz_bv_to_ut64(vm->vm->pc); | ||
| ut8 code[32] = { 0 }; | ||
| analysis->read_at(analysis, addr, code, sizeof(code)); | ||
| RzAnalysisOp op = { 0 }; | ||
| rz_analysis_op_init(&op); |
There was a problem hiding this comment.
I don't get it. It seems to me that rz_analysis_op_init needs to be called before every call to rz_analysis_op and rz_analysis_op_fini needs to be called after every call to rz_analysis_op.
So ‘Move it outside’ doesn't work? @pelijah
There was a problem hiding this comment.
Weird, rz_analysis_op_fini() doesn't work as expected so leave it as is.
There was a problem hiding this comment.
@XVilka We definetely should standardize *_fini() APIs behaviour.
wargio
approved these changes
May 1, 2024
pelijah
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
...
Test plan
...
Closing issues
...