Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always check the length before returning the head or tail #4459

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Always check the length before returning the head or tail #4459

merged 2 commits into from
Apr 23, 2024

Conversation

wargio
Copy link
Member

@wargio wargio commented Apr 23, 2024 •
edited
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This bug was found due a crash in silhouette.

RzPVector & RzVector seems to not check the length when invoking get head/tail methods.

rizinorg/rz-silhouette#10

@github-actions github-actions bot added the API label Apr 23, 2024
@wargio wargio added this to the 0.8.0 milestone Apr 23, 2024
@wargio
Copy link
Member Author

wargio commented Apr 23, 2024

Approved via side channels

@wargio wargio merged commit e08ceb9 into dev Apr 23, 2024
47 checks passed
@wargio wargio deleted the fix-pvec-tail-head-check branch April 23, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka Awaiting requested review from XVilka XVilka is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
API merge-when-green
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
1 participant
@wargio