Refactor TUI panels and fix several memleaks #4452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelijah
requested review from
wargio,
XVilka,
kazarmy,
thestr4ng3r and
ret2libc
as code owners
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
pelijah
force-pushed
the
panels_memleaks
branch
from
a31076c
to
126ef0c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
This TUI is buggy itself so am not sure that I didn't break something. Any suggestion how to test it? |
There was an idea of using Robot Framework for auto-testing TUI: #3959 |
|
As for manual testing - it's just better to do the same action in both before and after changes. |
This comment was marked as resolved.
This comment was marked as resolved.
pelijah
force-pushed
the
panels_memleaks
branch
from
f063221
to
2c2c6fa
Compare
pelijah
changed the title
pelijah
changed the title
XVilka
approved these changes
Apr 26, 2024
wargio
reviewed
Apr 26, 2024
wargio
reviewed
Apr 26, 2024
wargio
approved these changes
Apr 26, 2024
pelijah
changed the title
|
Waiting |
pelijah
force-pushed
the
panels_memleaks
branch
from
1e1b429
to
f37708a
Compare
XVilka
approved these changes
Apr 27, 2024
wargio
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
...
Test plan
...
Closing issues
Partially addresses #4055
...