Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rz_log and rz_core_notify functions usable with not-formatted strings. #4448

Merged
merged 5 commits into from
Apr 21, 2024
Merged

Add rz_log and rz_core_notify functions usable with not-formatted strings. #4448

merged 5 commits into from
Apr 21, 2024

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Apr 19, 2024 •
edited
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Adds functions which allow to use rz_log() and rz_core_notify_...() with simple strings (no printf like formatting).

Test plan

Added

Closing issues

...

@Rot127 Rot127 marked this pull request as draft April 19, 2024 11:42
@Rot127 Rot127 marked this pull request as ready for review April 19, 2024 12:42
XVilka
XVilka requested changes Apr 21, 2024
View reviewed changes
librz/util/log.c Outdated Show resolved Hide resolved
XVilka
XVilka requested changes Apr 21, 2024
View reviewed changes
librz/util/log.c Outdated Show resolved Hide resolved
librz/core/core.c Show resolved Hide resolved
@XVilka
Copy link
Member

XVilka commented Apr 21, 2024

Rename PR title and description as well, please

@Rot127 Rot127 changed the title Add binding log function for plugins without varg support. Add rz_log and rz_core_notify functions usable with not-formatted strings. Apr 21, 2024
@XVilka XVilka merged commit 34f1a9e into rizinorg:dev Apr 21, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@wargio wargio Awaiting requested review from wargio wargio is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

Assignees
No one assigned
Labels
API merge-when-green rz-test RzCore RzUtil
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rot127 @XVilka @wargio