-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove globals and refactor to complete implementation of logging. #4446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice finding. Apart from Doxygen - LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you are at it. Could you add a simple getter
for the current log level? Plugins can check it, when they print log messages.
Or, even better, add a logging function which takes the message as a string (not with vargs
). Because vargs
cannot be used from a few languages.
Actually, if you do spent the time to add the logging API for plugins, it might be a good idea add an additional argument, where plugins can pass their name.
|
tbh, there is an option which tells you the function, file and line where that occurs. |
Your checklist for this pull request
Detailed description
thread-safe
.RZ_LOG_SILLY
has been removed.fprintf
has been converted tofputs
.log.traplevel
tolog.abortlevel
and hide it in release builds.