Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python venv on OpenBSD #4437

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Use Python venv on OpenBSD #4437

merged 3 commits into from
Apr 16, 2024

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Apr 16, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr uses a Python venv for the OpenBSD build as recommended here. Using --break-system-packages felt too much like bad practice.

Test plan

All builds are green.

Closing issues

...

@kazarmy kazarmy marked this pull request as ready for review April 16, 2024 13:23
@XVilka XVilka merged commit c5b20a8 into dev Apr 16, 2024
48 checks passed
@XVilka XVilka deleted the bsd-open-python-venv branch April 16, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants