Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELF: skip visited segments in compute_symbols_from_segment() #4410

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

pelijah
Copy link
Contributor

@pelijah pelijah commented Mar 31, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

I am not familiar with ELF format but I think it is enough to memorize offset of visited symbol segments.
Related: #4386

Copy link
Member

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm honestly not sure if there are downsides to this. Could we have overlapping segments? That's the only edge case I can think of.

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it doesn't break anything I tried so far. Could always revert if counterexamples are found.

@XVilka
Copy link
Member

XVilka commented Apr 7, 2024

@wargio could you please take a look and lets merge it if you have no objections.

@wargio wargio merged commit 6280243 into rizinorg:dev Apr 7, 2024
44 checks passed
@pelijah pelijah deleted the elf_visited_symtab branch April 25, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants