Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TriCore IL: fix CSUB/CSUBN #4409

Merged
merged 2 commits into from
Mar 31, 2024
Merged

TriCore IL: fix CSUB/CSUBN #4409

merged 2 commits into from
Mar 31, 2024

Conversation

imbillow
Copy link
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

closes #4401

@pelijah
Copy link
Contributor

pelijah commented Mar 31, 2024

According to ISA condition also affects status flags. I think it would be better to add helper like f_overflow32 with condition.
UPD: I see it is already done as part of e_cadd.

librz/arch/isa/tricore/tricore_il.c Outdated Show resolved Hide resolved
@XVilka XVilka requested a review from pelijah March 31, 2024 15:20
@XVilka XVilka merged commit 8f7f03c into dev Mar 31, 2024
47 checks passed
@imbillow imbillow deleted the rzil-tricore-fix branch April 29, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tricore IL: CSUB/CSUBN are not properly implemented
3 participants