Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazarmy
requested review from
ret2libc,
wargio,
XVilka and
thestr4ng3r
as code owners
kazarmy
force-pushed
the
$-add-rzshell-façade
branch
from
ca4d74a
to
c2b9208
Compare
kazarmy
force-pushed
the
$-add-rzshell-façade
branch
from
df2eadf
to
596693c
Compare
wargio
reviewed
Mar 2, 2024
|
I love how github is scared by UTF-8. |
wargio
reviewed
Mar 2, 2024
| #include "rz_cmd.h" | ||
| #include "rz_core.h" | ||
|
|
||
| static int rz_cmd_alias(void *data, const char *input) { |
There was a problem hiding this comment.
maybe add a comment here as TODO where you explain that this needs to be refactored.
wargio
approved these changes
Mar 2, 2024
ASCII as the lowest common denominator |
5 tasks
|
This change regenerated |
|
I think there needs to be a way to ensure that there is no repeat of #4325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This pr is an initial conversion of
$to rzshell. Internally, it's still OLDINPUT code. Note that quoting rules have changed, I think for the better.Test plan
All builds are green.
Closing issues
Tracking issues: #1583, #1342