-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (i)CFG node type annotations + bug fix #4221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rot127
changed the title
Extract buffer read and analyze into function.
Add (i)CFG node type annotations + bug fix
Feb 14, 2024
Rot127
requested review from
ret2libc,
thestr4ng3r,
wargio,
XVilka and
kazarmy
as code owners
February 14, 2024 06:53
XVilka
requested changes
Feb 14, 2024
XVilka
requested changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason it fails tests on Windows: https://ci.appveyor.com/project/rizinorg/rizin/builds/49184102/job/s27n8bx7hn9ix46e#L4814
|
XVilka
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Fixes the bug that the buffer was not read again, before nodes to
RzAnalysisOp.jump/fail
were added.Additionally, and for testing specifically this, annotations are added to the CFG/iCFG nodes.
New annotations:
○
no-utf8:.
⤹
no-utf8:c
↓
no-utf8:e
↑
no-utf8:r
⇢
no-utf8:C
⭳
no-utf8:E
Exit is not yet tested, because it is not implemented yet. Exit nodes are nodes which exit the program abnormally, although the procedure should normally return (e.g. call to
abort()
).Test plan
All green + added
Closing issues
...