-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert rz_str_new
to rz_str_dup
#4178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! fix the declarations and it can be merged.
|
204c98d
to
3179b9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run python3 rz-bindgen/src/lint.py \
Translation unit diagnostic at <rizin/librz/core/cmd/cmd_eval.c:100:2>: expected expression
Translation unit diagnostic at <rizin/librz/core/cmd/cmd_eval.c:102:19>: use of undeclared identifier 'tmp'
Process completed with exit code 2.
Also formatting.
I've formatted all the files I've touched, Idk why it's breaking there. |
See the CI logs for the error messages, formatting also. |
Sure |
3179b9b
to
711b603
Compare
@HN026 The error might come from a different clang-format version on your side. Currently we have clang-format-16 in the CI. |
Yup I noticed will be pushing changes by evening. |
86e950b
to
33ab68f
Compare
Your checklist for this pull request
Detailed description
...
Test plan
...
Closing issues
Partially addresses #1176
...