New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove `rz_str_newf` from RzAsm Plugins #4150

Merged

XVilka merged 3 commits into rizinorg:dev from HN026:refactor_rzasm_plugins

Jan 25, 2024

Contributor

HN026 commented Jan 25, 2024 •

edited

Loading

Your checklist for this pull request

I've read the guidelines for contributing to this repository
I made sure to follow the project's coding style
I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
I've added tests that prove my fix is effective or that my feature works (if possible)
I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

Partially addresses #4127
...


          removed rz_str_newf from RzAsm Plugins

6c6a6f2

HN026 requested a review from wargio as a code owner

January 25, 2024 07:21

github-actions bot added ARM MIPS labels

wargio reviewed

View reviewed changes

librz/asm/p/asm_arm_cs.c Outdated Show resolved Hide resolved

wargio reviewed

View reviewed changes

librz/asm/p/asm_chip8.c Show resolved Hide resolved

wargio reviewed

View reviewed changes

librz/asm/p/asm_chip8.c Outdated Show resolved Hide resolved

wargio reviewed

View reviewed changes

librz/asm/p/asm_riscv_cs.c Outdated Show resolved Hide resolved

wargio reviewed

View reviewed changes

librz/asm/p/asm_sparc_cs.c Outdated Show resolved Hide resolved

wargio requested changes

View reviewed changes

Member

wargio left a comment

very good

XVilka requested changes

View reviewed changes

librz/asm/p/asm_mips_cs.c Show resolved Hide resolved

librz/asm/p/asm_riscv_cs.c Show resolved Hide resolved

HN026 added 2 commits

January 25, 2024 15:58


          changes

59357cb


          comment reorder

05da057

XVilka approved these changes

View reviewed changes

XVilka added the merge-when-green label

XVilka merged commit d9dd58c into rizinorg:dev

44 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARM merge-when-green MIPS