Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop -fno-strict-aliasing flag from capstone next build #4149

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Jan 24, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

After capstone-engine/capstone@cb2b879, the original reason for -fno-strict-aliasing for the capstone next build no longer applies and therefore the flag should be dropped.

Test plan

All builds (except the rz-bindgen build) are green.

Closing issues

Closes #4048.

@XVilka XVilka merged commit 54842b8 into rizinorg:dev Jan 24, 2024
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed fuzzing tests after updating capstone
2 participants