-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tools help and man pages #4145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow nice changes!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks better now. As something might have slipped my review, let more eyes check first before merging.
i am reverting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better now! Few things left.
@@ -1,60 +1,64 @@ | |||
.Dd Mar 31, 2020 | |||
.Dd Jan 24, 2024 | |||
.Dt RZ_TEST 1 | |||
.Sh NAME | |||
.Nm rz-test | |||
.Nd rizin regression testsuite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.It Fl v | ||
Show version number | ||
.It Fl q | ||
Quiet. | ||
.It Fl V |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like an order. Quiet mode
instead. Also remove the period.
|
all these changes should be applied also to the actual |
8554051
to
0440d35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's already a big improvement and can be merged as is. If there is something else left, we can fix it in other PRs.
Please fix verbs conjugation in the man pages PR. Some verbs are simple while others use third person. |
@byteninjaa0, please make those verb conjugation adjustments not only in C files - I can see there are a lot of inconsistencies in the man pages themselves, too. |
yes those should appear in the man pages too |
i think that the summary/description of the utilities should be in third person otherwise grammatically it would be wrong, isn't it? |
SQUASH ME
Your checklist for this pull request
Detailed description
Update man pages to reflect the current state of Rizin tools.
Test plan
Closing issues
Closes #3731