Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove global RzLine instance #4074

Merged
merged 3 commits into from
Jan 7, 2024
Merged

Remove global RzLine instance #4074

merged 3 commits into from
Jan 7, 2024

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Jan 5, 2024 •
edited
Loading

DO NOT SQUASH ME

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Remove global RzLine instance in preparation to removing global RzCons

Test plan

CI is green

Closing issues

Partially addresses #4055

@XVilka XVilka force-pushed the asan-fix-globals branch 3 times, most recently from 5bfe509 to c4ba94a Compare January 5, 2024 16:08
@XVilka XVilka force-pushed the asan-fix-globals branch 5 times, most recently from bd4a691 to f972020 Compare January 7, 2024 11:15
@XVilka XVilka changed the title [WIP] Remove global RzLine instance Remove global RzLine instance Jan 7, 2024
@XVilka XVilka marked this pull request as ready for review January 7, 2024 11:15
wargio
wargio reviewed Jan 7, 2024
View reviewed changes
librz/cons/dietline.c Outdated Show resolved Hide resolved
wargio
wargio approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@XVilka XVilka force-pushed the asan-fix-globals branch 2 times, most recently from faa4df9 to b17f725 Compare January 7, 2024 13:02
@XVilka XVilka mentioned this pull request Jan 7, 2024
Merged
3 tasks
@XVilka XVilka merged commit f5ca4b9 into dev Jan 7, 2024
47 checks passed
@XVilka XVilka deleted the asan-fix-globals branch January 7, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

Assignees
No one assigned
Labels
API dietline merge-when-green rizin rz-diff rz-test RzCons RzCore RzIO RzLang WinDbg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XVilka @wargio