Issue 3871 configure bin hashes #3951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or hash lists of different lengths
s1gse9v
requested review from
ret2libc,
wargio,
XVilka,
kazarmy and
thestr4ng3r
as code owners
wargio
reviewed
Nov 3, 2023
* Because the hashes computed for a given bin are now set by cb_binhashes in bin->default_hashes, they have to be set manually in test_bin.c
wargio
reviewed
Nov 3, 2023
wargio
requested changes
Nov 3, 2023
wargio
reviewed
Nov 4, 2023
There was a problem hiding this comment.
LGTM, just run ./sys/clang-format.py (requires to install first clang-format 16 https://github.com/rizinorg/rizin/blob/dev/DEVELOPERS.md#code-style)
XVilka
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
I have implemented the functionality requested in #3871.
iTnow computes and shows the algorithms specified inbin.hashes.default....
Test plan
I have tested using
test/db/cmd/cmd_i. I'm having trouble running the remaining tests however (even ondev) so more testing is probably required....
Closing issues
closes #3871
...