Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analysis/meta: minor cleanup #3948

Merged
merged 1 commit into from
Nov 6, 2023
Merged

analysis/meta: minor cleanup #3948

merged 1 commit into from
Nov 6, 2023

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Nov 2, 2023 •
edited
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Minor cleanup for RzAnalysisMetaItem.

Test plan

CI is green
Tested on some files locally (can't share)

@XVilka XVilka added the DWARF label Nov 2, 2023
@XVilka XVilka requested a review from imbillow November 2, 2023 14:33
wargio
wargio reviewed Nov 2, 2023
View reviewed changes
librz/analysis/meta.c Outdated Show resolved Hide resolved
wargio
wargio requested changes Nov 2, 2023
View reviewed changes
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comments

librz/analysis/analysis.c Outdated Show resolved Hide resolved
@XVilka XVilka force-pushed the asan-fuzz-fix-dwarf-double-free branch from d5db6b8 to 4875044 Compare November 2, 2023 16:15
@XVilka XVilka requested a review from wargio November 2, 2023 16:17
@XVilka XVilka force-pushed the asan-fuzz-fix-dwarf-double-free branch from 4875044 to b6dfe61 Compare November 6, 2023 12:11
@github-actions github-actions bot removed the DWARF label Nov 6, 2023
@XVilka XVilka changed the title Fix double free on DWARF analysis integration analysis/meta: minor cleanup Nov 6, 2023
@XVilka
Copy link
Member Author

XVilka commented Nov 6, 2023

@wargio @ret2libc as the original change is now unnecessary, I kept minor cleanup changes; take a look, it should be pretty straightforward.

@XVilka XVilka force-pushed the asan-fuzz-fix-dwarf-double-free branch from b6dfe61 to 75f6298 Compare November 6, 2023 13:06
@XVilka XVilka requested a review from kazarmy as a code owner November 6, 2023 13:06
@github-actions github-actions bot added the API label Nov 6, 2023
@XVilka XVilka merged commit a336296 into dev Nov 6, 2023
47 checks passed
@XVilka XVilka deleted the asan-fuzz-fix-dwarf-double-free branch November 6, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbillow imbillow imbillow approved these changes

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@wargio wargio Awaiting requested review from wargio wargio is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

Assignees
No one assigned
Labels
API RzAnalysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XVilka @wargio @ret2libc @imbillow